Conversation
Pretty sure the execution permissions are not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modeparameter to the safe FITS and HDF5 writing functionsmodefor those files (775 -> 664), since I am quite sure it is unnecessarychgrp desifor the final files (viashutil.chown)I have checked that the
write_LSS_scratchcpfunction works with my user at NERSC (withmode=0o660).Caveat: the
chgrp desipiece seems quite failsafe for DESI users at NERSC, but it may throw an exception in other environments. Not sure if anyone uses the LSS code outside of NERSC; if yes, I could add a try/except construction.Further considerations:
desi, it should be safe to restrict the default permissions to 660 for extra protection from unauthorized reading (even though some higher-level directories already wouldn't let non-desiusers through).mkCat_amtl.pyas long as there are no special needs there.